Skip to content

[CI/Build] Do not abort test collection when pexpect is missing #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GuoCheng24 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CI/Build] Do not abort test collection when pexpect is missing #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ dependencies = [
]

[project.optional-dependencies]
dev = ["pytest", "pexpect"]
acp = [
"agent-client-protocol>=0.8,<1",
]
Expand Down
7 changes: 6 additions & 1 deletion tests/test_tui_e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,14 @@
from pathlib import Path
from typing import Any, Callable

import pexpect
import pytest

# Imported lazily: pexpect is only needed by these TUI end-to-end tests.
# A module-level `import pexpect` runs before the skipif mark below, so on an
# install without it pytest aborts collection of the whole suite instead of
# skipping this one file.
pexpect = pytest.importorskip("pexpect")


ROOT = Path(__file__).resolve().parents[1]
pytestmark = pytest.mark.skipif(shutil.which("script") is None, reason="`script` is required for TUI e2e tests")
Expand Down