Repository navigation
Keep cutscenes in the game view in multiplayer - #1680
Merged
Merged
Conversation
In multiplayer the game switches to map view once about 200 tiles fit across the window, and what a cutscene draws in the world isn't drawn on the map. Danger Ores' spawn shot at zoom 0.35 lost its caption that way, and showed the map instead of the ground. Single player doesn't switch. Co-Authored-By: Claude Opus 5.5 <[email protected]>
lex
marked this pull request as ready for review
November 6, 2026 14:10
grilledham
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a server, the Danger Ores intro cutscene loses its caption when it zooms out to show spawn, and the player sees the map instead of the ground. The rest of the cutscene is fine, and the same shot looks right in single player.
In multiplayer the game switches a cutscene to map view once about 200 tiles fit across the window (
furthest_game_view = {distance = 200, max_distance = 500}), and what a cutscene draws in the world isn't drawn on the map. On a 6016x3268 window it switched at about zoom 0.43, and the spawn shot is at 0.35. The switch depends on the window size, so a large enough screen could lose the title and goal cards at zoom 0.5 too.register_running_cutscenenow sets the cutscene controller'sfurthest_game_viewto zoom 0.1, further out than any waypoint.Before, on a local server:

After, on a local server:

This also changes Crash Site. Its first cutscene has a shot at zoom 0.2 with a caption, which is past the limit, so on a server that shot should have been in map view with no caption. It now stays in the game view with the caption showing:
Testing
player.render_modechanges to map view during the zoom-out ondevelopand stays in the game view on this branch.developand on this branch.features/cutscene/cutscene_controller_tests.luachecks that a cutscene sets the limit, and fails with the line removed. It needs a real player, so it'sskip-headlessand CI doesn't run it. I ran it in a client, in single player. The switch itself only happens in multiplayer, so the test checks the limit and not the view.danger-oreandcrashsite, andluacheckis clean.Not in this PR
🤖 Generated with Claude Code