Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new function does not fully follow the repository’s required error initialization and verbose logging conventions.
1 open finding
What changed in this PR
Adds a public cmdlet for generating WinPE startup profiles across Boot-Assets and writable OSDCloud USB destinations.
Changes:
- Implements profile creation, validation, replacement, and destination discovery.
- Adds comprehensive Pester coverage and user documentation.
- Exports the cmdlet and bumps the module version.
| File | Description |
|---|---|
README.md |
Updates release details and command list. |
CHANGELOG.md |
Documents the new release. |
docs/about_winpestartup.md |
Explains profile creation and behavior. |
OSDCloud/OSDCloud.psd1 |
Updates version and exports the cmdlet. |
OSDCloud/public/WinOS/New-WinpeStartupProfile.ps1 |
Implements profile authoring. |
OSDCloud/public/WinOS/New-WinpeStartupProfile.Tests.ps1 |
Tests serialization, destinations, safety, and exports. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| [switch]$PassThru | ||
| ) | ||
|
|
||
| Write-Verbose "[$($MyInvocation.MyCommand.Name)] Start" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the
New-WinpeStartupProfilefunction for creating WinPE startup profiles, enhancing the module's capabilities. Update the module version to 26.10.13.1 and reflect these changes in the changelog and README.