Repository navigation
Enhance device inventory and synchronization features - #47
Merged
Merged
Conversation
…DCoreDevice feat(datetime): improve synchronization logic for Device DateTime with internet time test(device): add comprehensive tests for Show-OSDCloudDeviceInfo functionality docs(device): update documentation for Show-OSDCloudDeviceInfo and related functions
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Output ordering breaks the new test, sub-6-GB memory can evade warnings, and the public reference remains outdated.
3 open findings
What changed in this PR
Enhances device inventory collection, display, time-sync terminology, tests, and release documentation.
Changes:
- Adds richer hardware inventory and device display.
- Adds Pester coverage for inventory/display behavior.
- Updates time-sync wording and bumps version to 26.10.10.1.
| File | Description |
|---|---|
| README.md | Updates release highlights and version. |
| CHANGELOG.md | Documents the new release. |
| OSDCloud/OSDCloud.psd1 | Bumps module version. |
| OSDCloud/private/core-device/Initialize-OSDCoreDevice.ps1 | Expands hardware inventory. |
| OSDCloud/private/core-device/Initialize-OSDCoreDevice.Tests.ps1 | Tests inventory collection and serialization. |
| OSDCloud/private/core-device/Sync-OSDCoreDateTime.ps1 | Renames clock status terminology. |
| OSDCloud/public/WinOS/Show-OSDCloudDeviceInfo.ps1 | Displays the expanded inventory. |
| OSDCloud/public/WinOS/Show-OSDCloudDeviceInfo.Tests.ps1 | Tests device-information output and failures. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+105
to
+110
| foreach ($item in $deviceInfo.NetworkAdapters) { | ||
| if ($null -ne $item.GUID) { | ||
| $ipv4Display = if ($item.IPv4Addresses.Count -gt 0) { " [$($item.IPv4Addresses -join ', ')]" } else { '' } | ||
| Write-Host -ForegroundColor DarkGray "NetAdapter $($item.MACAddress): $($item.Name)$ipv4Display" | ||
| } | ||
| } |
Comment on lines
+141
to
+142
| if ($totalMemoryGB -lt 6) { | ||
| Write-Warning -WarningAction Continue "OSDCloud WinPE requires at least 6 GB of memory to function properly. Errors are expected." |
|
|
||
| .DESCRIPTION | ||
| Gathers and displays detailed hardware and environment information in Windows PE including system specifications, device identifiers, processor details, memory configuration, disk drives, and network adapters. Initializes the OSDCloud device environment and exports hardware WMI information to log files in the temporary directory. Validates system memory requirements and provides warnings if minimum specifications are not met. | ||
| Displays detailed hardware and environment information from the initialized OSDCoreDevice snapshot in Windows PE including system specifications, device identifiers, processor details, memory configuration, disk drives, and network adapters. Initialize-OSDCoreDevice owns hardware collection and diagnostic exports. Validates system memory requirements and provides warnings if minimum specifications are not met. If initialization fails, warns and displays unavailable inventory without querying hardware independently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve hardware inventory collection and display in OSDCoreDevice, and refine synchronization logic for Device DateTime with internet time. Add comprehensive tests for Show-OSDCloudDeviceInfo functionality and update documentation accordingly. Bump module version to 26.10.10.1 and reflect changes in the changelog and README.