Repository navigation
fix: title and sub-title spans disappears after deleting content - #624
Conversation
Changed Files
|
|
|
I can confirm it works nicely, though, thanks! I can click in the right place and edit, but it's relying on the user remembering that that's where the title and subtitle go and remembering they can do that. |
|
Also, |
joanise
left a comment
There was a problem hiding this comment.
todo: rebase and retest; check if you can use placeholder text instead of a non-breaking space
f17f422 to
8933089
Compare
|
Very nice. The only minor thing is that now if there is no subtitle, there is a gap between the title and the readalong and that gap is still there in the downloaded artefacts. Ditto if there is no title, or neither, the spaces remain occupied in the downloaded artefacts. Not really an issue for a standalone readalong or a page with just one, but I could see it being frustrating if someone was trying to embed multiple readalongs in one web page, or tried to place their own framing around our component. |
joanise
left a comment
There was a problem hiding this comment.
Beautiful. Thank you for this fix and the subsequent adjustments to it.
|
Question: this touches Update: I tested a web bundle downloaded using the PR preview, and it works fine with the latest web-component on npmjs, so I'm confident this is correct, there is no need to publish. |


PR Goal?
Fixes the issue where the title and sub-title elements would disappear from the page.
Fixes?
Fixes #587
Feedback sought?
That is works as intended. I've verified Safari and Chrome on macOS.
Priority?
Low.
Tests added?
No.
How to test?
This is a web component bug, using the Studio Web editor import an offline HTML file:
Confidence?
Medium.
Version change?