fix: resolve Viro paths via node for workspace/monorepo installs - #516
Open
busybox11 wants to merge 1 commit into
Open
fix: resolve Viro paths via node for workspace/monorepo installs#516busybox11 wants to merge 1 commit into
busybox11 wants to merge 1 commit into
Conversation
React-viro's expo config plugin hardcoded the package path as
`../node_modules/@reactvision/react-viro/{android,ios}` relative to the
generated android/ and ios/ dirs. That only holds when react-viro is
installed in the app's own node_modules.
In pnpm/yarn/npm workspaces the package is hoisted to the monorepo root
(or nested under .pnpm), so:
- Android: Gradle fails with "Configuring project ':gvr_common' without an
existing directory is not allowed".
- iOS: CocoaPods fails with "No podspec found for ViroKit" because the
generated pod :path points at a non-existent directory.
Add resolveViroAndroidRelativePath / resolveViroIosRelativePath that resolve
the package via require.resolve from the project root and emit a path relative
to the platform project root, falling back to the previous relative path so
flat installs behave exactly as before. Also add unit tests covering hoisted
monorepo, flat, and unresolvable layouts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React-viro's expo config plugin hardcoded the package path as
../node_modules/@reactvision/react-viro/{android,ios}relative to the generated android/ and ios/ dirs. That only holds when react-viro is installed in the app's own node_modules.In pnpm/yarn/npm workspaces the package is hoisted to the monorepo root (or nested under .pnpm), so:
Add resolveViroAndroidRelativePath / resolveViroIosRelativePath that resolve the package via require.resolve from the project root and emit a path relative to the platform project root, falling back to the previous relative path so flat installs behave exactly as before. Also add unit tests covering hoisted monorepo, flat, and unresolvable layouts.
Follow-up of #493, not sure why it got closed.