Skip to content

refactor(frontend): simplify remote save pipeline - #29

Merged
aksOps merged 1 commit into
mainfrom
fix/sonar-g006-remote-core
Aug 2, 2026
Merged

refactor(frontend): simplify remote save pipeline#29
aksOps merged 1 commit into
mainfrom
fix/sonar-g006-remote-core

Conversation

@aksOps

@aksOps aksOps commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace positional remote-save callbacks with a typed acknowledgement object
  • extract bounded helpers for legacy indexing, canonical ordering, request preparation, conflict retry, and acknowledgement delivery
  • migrate only the two App save callback sites
  • add characterization for identity, ordering, conflict, retry, wire, and callback contracts

Sonar scope

G006 Batch 1 targets 11 existing frontend-production findings:

AZ-8DLEBETN2Y3sJmEsG
AZ-8DLECETN2Y3sJmEsH
AZ-8DLECETN2Y3sJmEsK
AZ-8DLECETN2Y3sJmEsL
AZ-8DLECETN2Y3sJmEsM
AZ-8DLECETN2Y3sJmEsN
AZ-8DLECETN2Y3sJmEsO
AZ-8DLECETN2Y3sJmEsP
AZ-8DLECETN2Y3sJmEsQ
AZ-8DLECETN2Y3sJmEsR
AZ-8DLECETN2Y3sJmEsS

Expected OPEN delta after exact-main analysis: 11 fewer, with zero new issues.

Verification

  • signed head: 9de6898e59118301ac8eedb691b6963083f098eb
  • targeted Vitest: 201 passed
  • full frontend: 923 passed
  • frontend coverage: 98.29% statements, 95.31% branches, 98.74% functions, 99.46% lines
  • build: passed
  • Go race: 938 passed; aggregate coverage 97.8%, lowest package 95.6%
  • Go vet/format, Actionlint, ShellCheck, TypeScript, and diff checks: passed
  • normalized remote/App differential: zero unexpected semantic mismatches
  • independent code review: APPROVE
  • hosted run 30726489805: success in 10m53s
  • PR Sonar analysis 31473840-aa02-4690-a18b-668520f18e79: exact head, quality gate OK
  • new code: 99.3% coverage, 0.0% duplication, 0 issues, 0 accepted issues, 0 hotspots

No dependency, workflow, persistence-format, rendering, keyboard, or accessibility change.

@sonarqubecloud

sonarqubecloud Bot commented Aug 2, 2026

Copy link
Copy Markdown

@aksOps
aksOps merged commit c21b5d9 into main Aug 2, 2026
9 checks passed
@aksOps
aksOps deleted the fix/sonar-g006-remote-core branch August 2, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant