Skip to content

fix: preserve Sonar remediation contracts - #25

Merged
aksOps merged 5 commits into
mainfrom
fix/sonar-g004-contracts
Aug 1, 2026
Merged

fix: preserve Sonar remediation contracts#25
aksOps merged 5 commits into
mainfrom
fix/sonar-g004-contracts

Conversation

@aksOps

@aksOps aksOps commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

What changed

  • restore deterministic UTF-16 code-unit ordering for durable outbox traversal
  • add mutation-sensitive records, drain, and reconcile ordering regressions
  • replace the vacuous IdentityGate cleanup assertion with an observable StrictMode race test
  • add injection-shaped SQL scope/link/key characterization, including adverse cross-scope row ordering

Why

Independent review found that the previous localeCompare change altered durable ordering and that two remediation tests could pass without proving their intended contracts. This corrects those gaps before G004 is checkpointed.

Validation

  • npm test: 64 files, 905 tests; 98.24% statements, 95.21% branches, 98.72% functions, 99.43% lines
  • npm run build: passed
  • go test ./...: 897 tests passed
  • go test -race ./...: 897 tests passed
  • go vet ./...: passed
  • Go formatting and diff checks: passed
  • all five commits have valid ED25519 signatures
  • independent code review: APPROVE

@sonarqubecloud

sonarqubecloud Bot commented Aug 1, 2026

Copy link
Copy Markdown

@aksOps
aksOps merged commit 25d5984 into main Aug 1, 2026
9 checks passed
@aksOps
aksOps deleted the fix/sonar-g004-contracts branch August 1, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant