fix: resolve Sonar defects - #22
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
gitandghthrough absolute paths and reject relative test overridesRoot cause
The CI monitor relied on PATH resolution for child processes, allowing executable substitution through a writable PATH entry. The outbox also relied on the implicit
Array.prototype.sort()comparator, which Sonar reports as unreliable for Unicode strings.The separate browser-storage vulnerability was reviewed against the full data lifecycle and marked false positive in Sonar with an evidence comment: the bounded plain-text value is JSON-serialized, sent as JSON, and rendered only through React text nodes.
Impact
The monitor no longer executes relative/PATH-resolved GitHub or Git binaries. Outbox ordering is explicit without changing its intended string ordering contract. Sonar's
mainquality gate is already back to OK; this PR should close the remaining real vulnerability and bug after analysis.Validation
npm test— 64 files, 902 tests passed; coverage floors passednpm run buildnode scripts/ci/test_ci_monitor.cjsnode scripts/ci_monitor.cjs check-actionsgit diff --checkSonar CLI
verify --filewas attempted, but this organization does not have Agentic Analysis enabled (HTTP 403). The normal PR analysis remains the authoritative Sonar validation.