fix(security): remediate highest-risk Sonar findings - #18
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- fix three critical deterministic set-ordering bugs\n- harden outbox persistence and legacy migration against schema-tainted payloads\n- validate GitHub API path segments before request construction\n- add explicit Git option boundaries for validated revision operands\n\n## Verification\n\n- 902 frontend tests passed\n- frontend coverage: 98.23% statements, 95.21% branches, 98.72% functions, 99.43% lines\n- every Go package >=95%; aggregate 96.4%\n- Go race, vet, formatting, frontend build, Actionlint, ShellCheck, action-pin checks, CI hostile fixtures, npm audit all passed\n- independent code review: APPROVE\n\n## Sonar reconciliation\n\nTen separately reviewed SQL/confetti false positives are already resolved. This PR should close three bugs and five vulnerabilities on the exact candidate revision.