Repository navigation
Fix workspace allocation and reuse in matmul_all_reduce - #581
Draft
MashrafeeAryan wants to merge 5 commits into
Draft
MashrafeeAryan wants to merge 5 commits into
MashrafeeAryan wants to merge 5 commits into
Conversation
Keep the largest existing flag capacity across ranks when reallocating a workspace. Preserve the barrier and generation reset for tile layout changes. Add one-shot and two-shot GPU regression coverage for 64, 128, then 64 tiles.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When one or more GPUs are used, if one GPU needed new buffers while another skipped
allocation, the operation could hang and not proced,
Fixes #464.
What changes are included in this PR?
Are these changes tested?
GPU tests and performance measurements have not been run because
no AMD GPUs are available locally.