Skip to content

CI: parallel download steps, bump {up,down}load-artifacts versions #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthiasdiener wants to merge 1 commit into
base: dev
Choose a base branch
from
+26 −22
Open

CI: parallel download steps, bump {up,down}load-artifacts versions #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 24 additions & 20 deletions .github/workflows/rocm-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,12 +124,6 @@ jobs:
3rdparty/googletest \
3rdparty/hipify_torch

- name: Download build artifacts

@ipanfilo ipanfilo Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good change. Will it be also beneficial to put other downloads to this parallel step: repo checkout + submodules init?

uses: actions/download-artifact@v4
with:
name: te-rocm-wheels
path: dist/

- name: Host Diagnostics
run: |
echo "::group::Host Diagnostics"
Expand All @@ -139,9 +133,17 @@ jobs:
rocm-smi
echo "::endgroup::"

- name: Pull Docker Image
run: |
docker pull ${{ env.DOCKER_IMAGE }}
# Download artifacts and pull the Docker image concurrently
- parallel:
- name: Download build artifacts
uses: actions/download-artifact@v8
with:
name: te-rocm-wheels
path: dist/

- name: Pull Docker Image
run: |
docker pull ${{ env.DOCKER_IMAGE }}

- &run_container
name: Run Container
Expand Down Expand Up @@ -243,7 +245,7 @@ jobs:

- name: Upload logs
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: logs-sgpu-${{ matrix.arch_label }}
path: |
Expand Down Expand Up @@ -272,12 +274,6 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v6

- name: Download build artifacts
uses: actions/download-artifact@v4
with:
name: te-rocm-wheels
path: dist/

- name: Host Diagnostics
run: |
echo "::group::Host Diagnostics"
Expand All @@ -287,9 +283,17 @@ jobs:
rocm-smi
echo "::endgroup::"

- name: Pull Docker Image
run: |
docker pull ${{ env.DOCKER_IMAGE }}
# Download artifacts and pull the Docker image concurrently
- parallel:
- name: Download build artifacts
uses: actions/download-artifact@v8
with:
name: te-rocm-wheels
path: dist/

- name: Pull Docker Image
run: |
docker pull ${{ env.DOCKER_IMAGE }}

- *run_container

Expand Down Expand Up @@ -369,7 +373,7 @@ jobs:

- name: Upload logs
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: logs-mgpu-${{ matrix.arch_label }}-${{ matrix.framework }}
path: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/rocm-wheels-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ jobs:

- name: Upload wheels as GitHub Actions artifacts
if: success()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: te-rocm-wheels
path: |
Expand All @@ -227,7 +227,7 @@ jobs:

- name: Upload build logs on failure
if: failure()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v7
with:
name: te-rocm-build-logs
path: ${{ runner.temp }}/wheelhouse/logs/
Expand Down
Loading