Repository navigation
chore: update security scanning workflows #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,24 @@ | ||
| # To get started with Dependabot version updates, you'll need to specify which | ||
| # package ecosystems to update and where the package manifests are located. | ||
| # Please see the documentation for all configuration options: | ||
| # https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates | ||
| # Copyright Advanced Micro Devices, Inc. | ||
| # SPDX-License-Identifier: MIT | ||
| # | ||
| # Dependabot version updates. See | ||
| # https://docs.github.com/en/code-security/reference/supply-chain-security/dependabot-options-reference | ||
|
|
||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: "pip" # See documentation for possible values | ||
| directory: "/docs/sphinx" # Location of package manifests | ||
| open-pull-requests-limit: 10 | ||
| - package-ecosystem: "github-actions" | ||
| # "/" covers .github/workflows; composite actions keep their own `uses:` | ||
| # pins, so .github/actions has to be listed separately to get bumped. | ||
| directory: "/" | ||
| schedule: | ||
| interval: "daily" | ||
| labels: | ||
| - "documentation" | ||
| - "dependencies" | ||
| - "ci:docs-only" | ||
| reviewers: | ||
| - "samjwu" | ||
| # Wait a week before adopting newly released action versions. | ||
| cooldown: | ||
| default-days: 7 | ||
| exclude: | ||
| - "ROCm/rocm-security-gh*" | ||
| groups: | ||
| rocm-security-gh: | ||
| patterns: ["ROCm/rocm-security-gh*"] | ||
| github-actions: | ||
| patterns: ["*"] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Copyright Advanced Micro Devices, Inc. | ||
| # SPDX-License-Identifier: MIT | ||
| # | ||
| # bandit configuration | ||
| # Reference: https://bandit.readthedocs.io/en/latest/config.html | ||
| # Local scan: bandit --recursive . --configfile .github/scan_tools_configs/bandit.yml | ||
| # | ||
| # Bandit configuration for this repository's security scans. | ||
| # | ||
| # This file defines the complete scanner policy; | ||
| # Keep repository-specific suppressions and tuning here. | ||
|
|
||
| # Environment and generated-output exclusions support local scans; these | ||
| # paths are absent from clean CI checkouts. | ||
| exclude_dirs: | ||
| - .git | ||
| - .venv* | ||
| - venv* | ||
| - build | ||
| - dist | ||
| - node_modules | ||
| - __pycache__ |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| # Copyright Advanced Micro Devices, Inc. | ||
| # SPDX-License-Identifier: MIT | ||
| # | ||
| # gitleaks.toml | ||
| # Reference: https://github.com/gitleaks/gitleaks/blob/master/config/gitleaks.toml | ||
| # Local scan: gitleaks detect --source . --config .github/scan_tools_configs/gitleaks.toml | ||
| # | ||
| # Gitleaks configuration for this repository's security scans. | ||
| # | ||
| # This file defines the repository's complete Gitleaks policy. Recurring | ||
| # exclusions belong in this file. | ||
| # | ||
| # The `[extend]` section inherits Gitleaks' built-in rules, and the | ||
| # `[[allowlists]]` below apply to every rule. | ||
| # | ||
| # Use `.gitleaksignore` for one-off finding fingerprints. Add recurring path | ||
| # or regex exclusions to `[[allowlists]]` in this file. | ||
|
|
||
| title = "gitleaks config" | ||
|
|
||
| [extend] | ||
| # Inherit gitleaks' built-in ruleset (rotations, AWS, GCP, Slack, ...). | ||
| # Setting this to false would mean rolling our own detections, which | ||
| # is almost never what you want. | ||
| useDefault = true | ||
|
|
||
|
|
||
|
|
||
| # Allowlist field-vs-target reference: | ||
| # stopwords -> always matched against the SECRET value. | ||
| # regexes -> matched against `regexTarget` (default: "secret"). | ||
| # regexTarget -> "secret" | "match" | "line". | ||
| # Use "match" or "line" when the "tell" is the variable name or | ||
| # surrounding syntax, not the value itself. | ||
|
|
||
| [[allowlists]] | ||
| # Allowlist by location only where a real first-party secret structurally | ||
| # can't live. Dependency lock files qualify: their contents are generated | ||
| # from a manifest, and the high-entropy strings they carry are artifact | ||
| # digests rather than credentials. Add vendored third-party trees here as | ||
| # callers bring them in, one explicit path per entry. | ||
| description = "Generated dependency lock files" | ||
| paths = [ | ||
| '''.*\.lock$''', | ||
| ] | ||
|
|
||
| [[allowlists]] | ||
| description = "Test fixtures using well-known dummy variable names" | ||
| # The "tell" here is the variable name on the same line, not the value | ||
| # (the value is a random-looking string by design). Match against the | ||
| # full rule match (variable + value) so we anchor on the identifier. | ||
| regexTarget = "match" | ||
| regexes = [ | ||
| '''(?i)\bINVALID_TOKEN\s*=''', | ||
| '''(?i)\bwrong_secret\s*=''', | ||
| # Explicit test-only secret identifiers | ||
| '''(?i)\btest_secret\s*=''', | ||
| '''(?i)\bdummy_secret\s*=''', | ||
| '''(?i)\bfake_secret\s*=''', | ||
| '''(?i)\bexample_secret\s*=''' | ||
| ] | ||
|
|
||
| [[allowlists]] | ||
| description = "Public artifact digests (variable names ending in SHA256/512/MD5)" | ||
| # SHA-256/512/MD5 hashes of public artifacts are not secrets. | ||
| regexTarget = "line" | ||
| regexes = [ | ||
| '''[A-Z][A-Z0-9_]*SHA256\s*[=:]''', | ||
| '''[A-Z][A-Z0-9_]*SHA512\s*[=:]''', | ||
| '''[A-Z][A-Z0-9_]*MD5\s*[=:]''', | ||
| ] |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Copyright Advanced Micro Devices, Inc. | ||
| # SPDX-License-Identifier: MIT | ||
| # | ||
| # trivy configuration | ||
| # Reference: https://trivy.dev/latest/docs/references/configuration/config-file/ | ||
| # Local scan: trivy fs --config .github/scan_tools_configs/trivy.yml . | ||
| # | ||
| # Trivy configuration for this repository's security scans. | ||
| # | ||
| # This file defines the complete scanner policy; | ||
| # Keep repository-specific suppressions and tuning here. | ||
|
|
||
| # Environment and generated-output exclusions support local scans; these | ||
| # paths are absent from clean CI checkouts. | ||
| scan: | ||
| skip-dirs: | ||
| - .git | ||
| - .venv* | ||
| - venv* | ||
| - build | ||
| - dist | ||
| - node_modules | ||
| - __pycache__ |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Copyright Advanced Micro Devices, Inc. | ||
| # SPDX-License-Identifier: MIT | ||
| # | ||
| # zizmor configuration | ||
| # Reference: https://docs.zizmor.sh/configuration/ | ||
| # Local scan: zizmor --config .github/scan_tools_configs/zizmor.yml . | ||
| # | ||
| # Zizmor configuration for this repository's security scans. | ||
| # | ||
| # This file defines the complete scanner policy; | ||
| # Keep repository-specific suppressions and tuning here. | ||
| # | ||
| # Add rule-specific settings and suppressions under `rules:`. | ||
|
|
||
| rules: {} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # Copyright Advanced Micro Devices, Inc. | ||
| # SPDX-License-Identifier: MIT | ||
| # | ||
| # Pre-commit security gate: fast, PR-side security scanners that run on | ||
| # every pull request. Scanner selection and policy are defined by the pinned | ||
| # ROCm/rocm-security-gh `security-baseline.yml` reusable workflow. | ||
| # | ||
| # Requests human-readable reports only: findings are uploaded as a build | ||
| # artifact and printed to the job summary, never to the Security tab, so | ||
| # fork PRs (which never receive elevated tokens) behave identically to | ||
| # same-repo PRs. See the scheduled counterpart (weekly-security-scan.yml) | ||
| # for the SARIF / code-scanning upload. | ||
|
|
||
| name: Security scan (PR) | ||
|
|
||
| on: | ||
| pull_request: | ||
| # Spelled out the default to avoid confusion. | ||
| types: [opened, synchronize, reopened] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| security: | ||
| name: Security scan | ||
| permissions: | ||
| actions: read | ||
| contents: read | ||
| pull-requests: write | ||
| uses: ROCm/rocm-security-gh/.github/workflows/security-baseline.yml@228e62369c5d8b677215f8a112ea0c8e8119c58f # v1.0.6 | ||
| with: | ||
| report_formats: human | ||
| bandit_config_path: .github/scan_tools_configs/bandit.yml | ||
| gitleaks_config_path: .github/scan_tools_configs/gitleaks.toml | ||
| trivy_config_path: .github/scan_tools_configs/trivy.yml | ||
| zizmor_config_path: .github/scan_tools_configs/zizmor.yml |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # Copyright Advanced Micro Devices, Inc. | ||
| # SPDX-License-Identifier: MIT | ||
| # | ||
| # Weekly security scan: runs on a fixed cadence and pushes SARIF findings | ||
| # to the repository's code-scanning Security tab. Complements | ||
| # `pr-security-scan.yml`, which scans only what changed in a PR and | ||
| # uploads reviewer-readable artifacts for in-review browsing. | ||
|
|
||
| name: Security scan (Weekly) | ||
|
|
||
| on: | ||
| # Run every Saturday at 10:00 UTC. | ||
| schedule: | ||
| - cron: "0 10 * * 6" | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| security: | ||
| name: Security scan | ||
| # Only the job that uploads SARIF gets write access to code scanning. | ||
| permissions: | ||
| contents: read | ||
| security-events: write | ||
| uses: ROCm/rocm-security-gh/.github/workflows/security-baseline.yml@228e62369c5d8b677215f8a112ea0c8e8119c58f # v1.0.6 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The baseline called here brings its own CodeQL with it: I think it would be better to drop |
||
| with: | ||
| scan_mode: all | ||
| report_formats: sarif | ||
| bandit_config_path: .github/scan_tools_configs/bandit.yml | ||
| gitleaks_config_path: .github/scan_tools_configs/gitleaks.toml | ||
| trivy_config_path: .github/scan_tools_configs/trivy.yml | ||
| zizmor_config_path: .github/scan_tools_configs/zizmor.yml | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we keep this updater? It's what's going to address the trivy findings. Keep it together with the labels that were also deleted below.