Repository navigation
fix(notices): keep the LGPL-2.1 text; zlib ships only in the HRX tarball - #814
Merged
Merged
Conversation
The HRX Linux portable tarball still bundles LGPL-2.1 system libraries (GnuTLS, libtasn1, librtmp, keyutils, glibc's libmvec and libresolv) as part of libcurl's dependency closure, so the LGPL-2.1 text has to stay even though FFmpeg no longer needs it. Without the static zlib build only the HRX tarball carries libz.so.1 (as a libcurl dependency); the XRT tarball has none. Co-Authored-By: Claude <[email protected]>
|
You can't ever be compliant in this repo. The closed kernels don't fit Any of the other licenses, only MIT. Being closed in the first place is AMD's very own stupid decision and you're not going to fix that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #813, which was merged a few minutes before this fix was pushed to its branch.
Summary
libmvec/libresolv. Dropping the text would leave that tarball with less license text than it had before build: drop FFmpeg from the build and packages #813.libz.so.1(as a libcurl dependency); the XRT tarball has none. I checked this against the build: drop FFmpeg from the build and packages #813 CI artifacts.Text-only change to
THIRD_PARTY_NOTICES.txt. The section numbering and the table of contents are unchanged (28 entries).Remaining notice gaps in the HRX tarball predate #813 and will be handled separately:
libhrx) is not listed.The planned fix is to bundle an explicit set of libraries and link curl statically, which removes the LGPL libraries from the package instead of documenting them.
🤖 Generated with Claude Code