Repository navigation
fix(whisper): stop the Linux XRT engine printing an aiebu banner - #812
Merged
Merged
Conversation
The Linux XRT libwhisper_npu.so vendored in f4f9341 printed "Header version 0.1 / Device Generation: 4 / Cols, Rows, NumMemRows ... / TransactionSize / NumOps / UID:" to stdout on every kernel setup: about 1,400 blocks for a 110 s clip, 4 MB of server log in the Linux ASR test. The CI host that built it had XRT under /opt/xilinx/xrt/lib, which the engine's link line searched before FastFlowLM_IRON's own libaiebu.a, so it linked that XRT's aiebu. Rebuilt the Whisper engine (Linux and Windows, HRX and XRT) and the five Whisper xclbins from FastFlowLM_IRON 315b9cab1 (PR #66, IRON CI run 39151964873), which links the repo's libaiebu.a by path. Only the Linux XRT library changes in substance: no banner, and the same aiebu and toolchain as the engines before f4f9341. The engine and kernel sources are otherwise those of f4f9341; the other binaries differ only by rebuild (the Windows import libraries are identical). Model weights are unchanged. Co-Authored-By: Claude <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Linux XRT
libwhisper_npu.sovendored in #794 (f4f9341f) prints an aiebu debug banner to stdout on every kernel setup:That's about 1,400 blocks for a 110 s clip. In the Linux ASR test it filled about 4 MB of server log. The other platforms' logs are 75 KB. The HRX
.so, the Windows DLLs and the engine before #794 don't print it.The build host had XRT under
/opt/xilinx/xrt/lib, and the engine's link line searched that directory before FastFlowLM_IRON's ownlibaiebu.a. So-laiebupicked up that XRT's aiebu, which has the banner and doesn't match the aiebu headers the engine compiles against.Change
The Whisper engine is rebuilt for Linux and Windows, HRX and XRT. The five Whisper xclbins are rebuilt too. Everything comes from FastFlowLM_IRON
315b9cab1(internal PR #66, CI run 39151964873), which links the repo'slibaiebu.aby path..so: the only real change. It has no banner, and its aiebu exports and toolchain (GCC 13.3) now match the other vendored engines.Validation
strings src/lib/xrt/libwhisper_npu.so | grep -c 'Header version'returns 0 (it was 1).5a8e0b98, which includes fix(whisper): make the ASR decode loop behave like Whisper #794, on Linux XRT and HRX:🤖 Generated with Claude Code