Skip to content

fix(qwen3.5): stop at max_tokens instead of one token past it #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manueldomke wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(qwen3.5): stop at max_tokens instead of one token past it #778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/common/AutoModel/modeling_qwen3_5vl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,17 @@ std::string Qwen3_5VL::generate(chat_meta_info_t& meta_info, int length_limit, s
reason = MAX_LENGTH_REACHED;
return result;
}
while (this->total_tokens < this->MAX_L){
while (true){
// The first token is drawn before the loop, so the limit can already be
// reached here -- with max_tokens=1 it always is. Checked only after a
// draw, the loop would draw and emit one token past the limit.
if ((length_limit > 0) && (meta_info.generated_tokens >= length_limit)){
reason = MAX_LENGTH_REACHED;
break;
}
if (this->total_tokens >= this->MAX_L){
break;
}
if (is_cancelled()) {
reason = CANCEL_DETECTED;
// reset stream content
Expand Down Expand Up @@ -414,10 +424,6 @@ std::string Qwen3_5VL::generate(chat_meta_info_t& meta_info, int length_limit, s
break;
}
meta_info.generated_tokens++;
if ((length_limit > 0) && (meta_info.generated_tokens >= length_limit)){
reason = MAX_LENGTH_REACHED;
break;
}
}
meta_info.decoding_duration = (uint64_t)(time_utils::cast_to_us(this->profiler_list[DECODING_TIME].get_total_time()).first) * 1e3;
meta_info.stop_reason = reason;
Expand Down