Skip to content

Fix ROCm dependency discovery after cget/rbuild toolchain setup - #5224

Merged
causten merged 2 commits into
developfrom
kqian1/cmake-perfix-path-fix
Sep 1, 2026
Merged

Fix ROCm dependency discovery after cget/rbuild toolchain setup#5224
causten merged 2 commits into
developfrom
kqian1/cmake-perfix-path-fix

Conversation

@kentqian

Copy link
Copy Markdown
Contributor

Summary

  • Append ROCm prefix paths after project() so they are not overwritten by the cget toolchain.
  • Restore rbuild package behavior without requiring users to set CMAKE_PREFIX_PATH manually.

Testing

  • Built packages with CMAKE_PREFIX_PATH unset.
  • Verified TheRock DEB contents install under /opt/rocm/extras-10.

Changelog Category

Add a CHANGELOG.md entry for any option other than Not Applicable

    • Added: New functionality.
    • Changed: Changes to existing functionality.
    • Removed: Functionality or support that has been removed. (Compared to a previous release)
    • Optimized: Component performance that has been optimized or improved.
    • Resolved Issues: Known issues from a previous version that have been resolved.
    • Not Applicable: This PR is not to be included in the changelog.

Follow the LLVM AI Tool Use Policy for contributions using AI.

@kentqian kentqian self-assigned this Aug 31, 2026
@kentqian
kentqian requested a review from causten as a code owner August 31, 2026 17:28
Copilot AI lite review requested due to automatic review settings August 31, 2026 17:28
@kentqian kentqian added dependencies Pull requests that update a dependency file Continous Integration Pull request updates parts of continous integration pipeline labels Aug 31, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the top-level CMake configuration to make ROCm dependency discovery robust when using cget/rbuild toolchain setups, by ensuring the ROCm prefix paths are appended after project() (so toolchain-provided post-project() includes don’t overwrite them).

Changes:

  • Move the list(APPEND CMAKE_PREFIX_PATH ...) for ROCm-related prefixes to after project(migraphx ...).
  • Preserve rbuild package usability when CMAKE_PREFIX_PATH is unset by users.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@causten
causten merged commit ce56a12 into develop Sep 1, 2026
33 checks passed
@causten
causten deleted the kqian1/cmake-perfix-path-fix branch September 1, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Continous Integration Pull request updates parts of continous integration pipeline dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants