Fix ROCm dependency discovery after cget/rbuild toolchain setup - #5224
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the top-level CMake configuration to make ROCm dependency discovery robust when using cget/rbuild toolchain setups, by ensuring the ROCm prefix paths are appended after project() (so toolchain-provided post-project() includes don’t overwrite them).
Changes:
- Move the
list(APPEND CMAKE_PREFIX_PATH ...)for ROCm-related prefixes to afterproject(migraphx ...). - Preserve
rbuild packageusability whenCMAKE_PREFIX_PATHis unset by users.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
causten
approved these changes
Aug 31, 2026
pfultz2
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
project()so they are not overwritten by the cget toolchain.rbuild packagebehavior without requiring users to setCMAKE_PREFIX_PATHmanually.Testing
CMAKE_PREFIX_PATHunset./opt/rocm/extras-10.Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot ApplicableFollow the LLVM AI Tool Use Policy for contributions using AI.