Skip to content

Format - #5222

Merged
pfultz2 merged 1 commit into
developfrom
format-update
Aug 31, 2026
Merged

Format#5222
pfultz2 merged 1 commit into
developfrom
format-update

Conversation

@pfultz2

@pfultz2 pfultz2 commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Motivation

Technical Details

Changelog Category

Add a CHANGELOG.md entry for any option other than Not Applicable

    • Added: New functionality.
    • Changed: Changes to existing functionality.
    • Removed: Functionality or support that has been removed. (Compared to a previous release)
    • Optimized: Component performance that has been optimized or improved.
    • Resolved Issues: Known issues from a previous version that have been resolved.
    • Not Applicable: This PR is not to be included in the changelog.

Follow the LLVM AI Tool Use Policy for contributions using AI.

Copilot AI lite review requested due to automatic review settings August 31, 2026 15:22
@pfultz2
pfultz2 requested a review from causten as a code owner August 31, 2026 15:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR applies formatting and alignment updates across multiple test and GPU target/source files to improve readability and keep style consistent.

Changes:

  • Re-indented and aligned multi-line function calls and initializer lists across tests and core sources
  • Collapsed/simple-reformatted a few small blocks (e.g., single-return stub, logging stream formatting)
  • Minor whitespace normalization around variable declarations

Reviewed changes

Copilot reviewed 6 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/verify/test_masked_reduce_half.cpp Adjusts indentation/alignment for slice instruction construction in test
test/verify/test_gru_forward_layout.cpp Aligns indentation for transpose instruction call
test/verify/test_gru_bidirct_layout.cpp Aligns indentation for transpose instruction call
test/simplify_algebra_test.cpp Normalizes spacing in instruction assignment within test
test/ref/eval_expr_from_shape.cpp Adjusts indentation for shape construction argument
test/op_sym_compute_test.cpp Aligns indentation in symbolic_compute calls
test/onnx/parse/softsign_dyn_test.cpp Reformats instruction construction lines for readability
test/onnx/parse/softplus_dyn_test.cpp Reformats instruction construction lines for readability
src/targets/gpu/target.cpp Aligns designated initializer formatting for layout_convolution pass config
src/targets/gpu/mlir.cpp Reformats MLIR-disabled stub into single-line implementation
src/targets/gpu/kernels/include/migraphx/kernels/winograd_conv_fp32.hpp Re-indents multi-line expressions/ternaries for readability
src/targets/gpu/compile_ops.cpp Reformats log streaming into a cleaner wrapped statement
src/simplify_algebra.cpp Reformats assert/lambda indentation and reflows replace/insert_instruction calls
src/onnx/parse_gru.cpp Aligns indentation for builder call arguments
src/include/migraphx/op/dyn_slice.hpp Re-indents attribute arrays and normalize_indices call arguments
src/fuse_reduce.cpp Reflows matcher construction for readability

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@pfultz2
pfultz2 merged commit 3b97d0c into develop Aug 31, 2026
24 of 31 checks passed
@pfultz2
pfultz2 deleted the format-update branch August 31, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants