Format - #5222
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR applies formatting and alignment updates across multiple test and GPU target/source files to improve readability and keep style consistent.
Changes:
- Re-indented and aligned multi-line function calls and initializer lists across tests and core sources
- Collapsed/simple-reformatted a few small blocks (e.g., single-return stub, logging stream formatting)
- Minor whitespace normalization around variable declarations
Reviewed changes
Copilot reviewed 6 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/verify/test_masked_reduce_half.cpp | Adjusts indentation/alignment for slice instruction construction in test |
| test/verify/test_gru_forward_layout.cpp | Aligns indentation for transpose instruction call |
| test/verify/test_gru_bidirct_layout.cpp | Aligns indentation for transpose instruction call |
| test/simplify_algebra_test.cpp | Normalizes spacing in instruction assignment within test |
| test/ref/eval_expr_from_shape.cpp | Adjusts indentation for shape construction argument |
| test/op_sym_compute_test.cpp | Aligns indentation in symbolic_compute calls |
| test/onnx/parse/softsign_dyn_test.cpp | Reformats instruction construction lines for readability |
| test/onnx/parse/softplus_dyn_test.cpp | Reformats instruction construction lines for readability |
| src/targets/gpu/target.cpp | Aligns designated initializer formatting for layout_convolution pass config |
| src/targets/gpu/mlir.cpp | Reformats MLIR-disabled stub into single-line implementation |
| src/targets/gpu/kernels/include/migraphx/kernels/winograd_conv_fp32.hpp | Re-indents multi-line expressions/ternaries for readability |
| src/targets/gpu/compile_ops.cpp | Reformats log streaming into a cleaner wrapped statement |
| src/simplify_algebra.cpp | Reformats assert/lambda indentation and reflows replace/insert_instruction calls |
| src/onnx/parse_gru.cpp | Aligns indentation for builder call arguments |
| src/include/migraphx/op/dyn_slice.hpp | Re-indents attribute arrays and normalize_indices call arguments |
| src/fuse_reduce.cpp | Reflows matcher construction for readability |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot ApplicableFollow the LLVM AI Tool Use Policy for contributions using AI.