Skip to content

Update MIGraphX EP shim to default to the AMD pci vendor ID - #5221

Open
TedThemistokleous wants to merge 1 commit into
developfrom
update_pluggin_ep_shim
Open

Update MIGraphX EP shim to default to the AMD pci vendor ID#5221
TedThemistokleous wants to merge 1 commit into
developfrom
update_pluggin_ep_shim

Conversation

@TedThemistokleous

Copy link
Copy Markdown
Collaborator

Motivation

Update shim python script for using example code with pluggin EP and ROCm 7.14.x builds

Technical Details

Original change let us reuse scripts for new EP builds but older ROCm 7.14.x builds of OnnxRT MIGraphX EP don't include the API item for AMD's vendor ID breakout.

Modifying the script so we just hardcode the vendorID for APIs that don't contain the attribute

Changelog Category

Add a CHANGELOG.md entry for any option other than Not Applicable

    • Added: New functionality.
    • Changed: Changes to existing functionality.
    • Removed: Functionality or support that has been removed. (Compared to a previous release)
    • Optimized: Component performance that has been optimized or improved.
    • Resolved Issues: Known issues from a previous version that have been resolved.
    • Not Applicable: This PR is not to be included in the changelog.

Follow the LLVM AI Tool Use Policy for contributions using AI.

@TedThemistokleous
TedThemistokleous requested review from ahsan-ca and eddieliao and removed request for causten August 31, 2026 14:50
@TedThemistokleous TedThemistokleous self-assigned this Aug 31, 2026
@TedThemistokleous TedThemistokleous added onnxruntime PR changes interaction between MIGraphX and Onnxruntime bugfix Fixes a bug found in the code. Continous Integration Pull request updates parts of continous integration pipeline labels Aug 31, 2026
except AttributeError:
MIGRAPHX_VENDOR_ID = 0x1002 # AMD PCI vendor ID fallback

def _find_migraphx_plugin_lib():

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[format.py] reported by reviewdog 🐶

Suggested change
def _find_migraphx_plugin_lib():
def _find_migraphx_plugin_lib():

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes a bug found in the code. Continous Integration Pull request updates parts of continous integration pipeline onnxruntime PR changes interaction between MIGraphX and Onnxruntime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant