Use rocmlirtriton as the compiler backend - #5215
Conversation
| # on python3-packaging, and a dpkg-owned copy of packaging cannot be uninstalled | ||
| # by pip when requirements-py.txt pins a different version. | ||
| pip3 install setuptools wheel pipx | ||
| pip3 install setuptools wheel pipx pybind11 |
There was a problem hiding this comment.
pybind should not be installed through pip. We already install pybind11 in the requirements.txt file. Also this should not be needed since we arent using the python bindings of triton.
There was a problem hiding this comment.
In tools/install_prereqs.sh the install of py-requirements.txt happens after rbuild prepare , I'll try swapping the order
There was a problem hiding this comment.
Dont change the order. The py-requirements.txt is for python and rbuild and requirements.txt are for C++ dependencies.
There was a problem hiding this comment.
Pull request overview
Updates the project’s dependency setup to use ROCm/rocmlirTriton in place of ROCm/rocMLIR, aligning the build/prereq tooling with the new compiler backend repository.
Changes:
- Switch third-party dependency pin from
ROCm/rocMLIRtoROCm/rocmlirTritoninrequirements.txt. - Update
rbuild.inito ignoreROCm/rocmlirTritonin the same CI profiles that already ignoreROCm/rocMLIR. - Add
pybind11to Python requirements and reorder therbuild preparestep in the prereq installer script.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/requirements-py.txt | Adds a pinned pybind11 Python package requirement. |
| tools/install_prereqs.sh | Reorders Python package installation vs rbuild prepare for prereqs setup. |
| requirements.txt | Replaces the rocMLIR dependency pin with rocmlirTriton. |
| rbuild.ini | Adds rocmlirTriton to the ignored deps list for selected rbuild profiles. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Motivation
Swap out rocmlir with rocmlirTriton
Technical Details
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot ApplicableFollow the LLVM AI Tool Use Policy for contributions using AI.