Repository navigation
Conversation
Author
|
I have tested and it works. |
Collaborator
|
Hi @KubeKyrie , thanks for the PR, and apologies for the delay. Heads-up: we just merged a large internal iteration into
One thing to watch when you rebase: #17 rewrote a large part of Could you please:
Thanks for digging into this — the dead-code path was easy to miss. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Read SSH public keys from the same
rlark-ssh-keysSecret used by Gateway, regardless of database configuration. Match keys by username and preserve usernames containing hyphens. Add regression tests and update English and Chinese documentation.Motivation and Context
Gateway stores registered keys in a Secret, but Server previously queried PostgreSQL when
--db-configwas enabled. This caused valid registered keys to fail authentication withPermission denied (publickey).How has this been tested?
go test ./apps/rlark/pkg/server/....git diff --check.The full repository test suite was not run.
Types of changes
Checklist: