ci: run the test suite on push and PR - #3
Merged
Merged
Conversation
This repo had no CI, and app.MPPT now depends on it from git (tracking main), so a break here reaches the application with nothing in between to catch it. All 7 tests run on a clean runner. The integration test starts a real amqtt broker on localhost, so it needs no hardware and no RIAPS platform install — amqtt was already declared in [dependency-groups] dev, it just was never run anywhere but a developer's machine. tests/need_update_test_MqttDevice.py is the one exception: it imports riaps.ctrl from the platform .deb, and its filename already keeps pytest from collecting it. pixi.lock is re-locked in the same commit. It was written in Feb 2026 and had drifted from pyproject.toml, so setup-pixi's --locked install would have failed on the first run. Verified the suite still passes against the refreshed lock.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repo had no CI.
app.MPPTnow depends on it from git (trackingmain),so a break here reaches the application with nothing in between to catch it.
What runs
All 7 tests, on a clean
ubuntu-latestrunner:The integration test (
tests/integration/test_mqthread.py) starts a realamqttbroker on localhost — no hardware, no RIAPS platform install.amqttwas already declared in
[dependency-groups] dev; it had just never runanywhere but a developer's machine.
tests/need_update_test_MqttDevice.pyis the one exception: it importsriaps.ctrl, which ships in the platform.deband is not pip-installable.Its filename already keeps pytest from collecting it, so no skip guard is
needed.
pixi.lock is re-locked here too
The committed lock was written in Feb 2026 and had drifted from
pyproject.toml.setup-pixiinstalls with--locked, so the first CI runwould have failed on the lock, not on the code. Re-locked and re-ran the suite
against it — still 7 passed.
Cost control
Same shape as
app.MPPT's workflow:concurrencywithcancel-in-progresssoa new push cancels the previous run, and
timeout-minutes: 15.