Repository navigation
Wiki比較パネルの初期表示不一致を修正 - #17
Open
NishikawaKoharu wants to merge 1 commit into
Open
NishikawaKoharu wants to merge 1 commit into
NishikawaKoharu wants to merge 1 commit into
Conversation
yacchin1205
reviewed
Nov 13, 2026
| if (compareVersion !== 'previous') { | ||
| return String(compareVersion); | ||
| } | ||
| var select = document.getElementById('compareVersionSelect'); |
There was a problem hiding this comment.
revious を指定しても、対応する選択肢を取得できなかった場合は、黙って current に切り替わる点が気になりました。というのと、 RCOSDP/RDM-osf.io#827 と同じ指摘をしているのですが、二重管理になっていませんでしょうか。両リポジトリの役割と、修正を同期する方針を確認させてください。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix a Wiki Compare frontend bug: opening Compare shows "(Current)" in the compare dropdown, but the actual diff is against the previous version. Selecting the previous version does not change the diff; selecting "(Current)" again is required before the comparison matches the label.
Server-side default changes, remapping, and tests must be landed together with the RDM-osf.io companion PR (
feature/fix-wiki-compare-default-current).Changes
displaySourcefrom live edits even while Compare is closed (so opening Compare diffs against unsaved edits)previoustocurrentresolveCompareVersion()to normalizeprevious/ empty values to the real dropdown valueChanged files:
addons/wiki/static/wikiPageMilkdown.jswebsite/static/js/pages/wiki-edit-page.jsQA Notes
(Verify together with the RDM-osf.io companion PR.)
Documentation
Side Effects
Ticket
https://redmine.devops.rcos.nii.ac.jp/issues/63974