Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@

**Jump:** [English](#english) · [日本語](#japanese)

- Version / 版: 0.1 — 2026-11-05. **Learned:** fixing tracking bullets does not resolve a conflicting universal bootstrap procedure. / 追跡の箇条書きを直しても、全対象に適用する初回構築手順の矛盾は解消しないと分かった。
- Version / 版: 0.2 — 2026-11-18. **Learned:** a public record links only to public records: the link to r2, a record about private repositories that is kept in the private guide, became plain text. / 公開の記録からは公開の記録にだけリンクする。非公開のリポジトリについての r2 は非公開のガイドに保管しているので、リンクを外して文字だけにした。
0.1 — 2026-11-05. **Learned:** fixing tracking bullets does not resolve a conflicting universal bootstrap procedure. / 追跡の箇条書きを直しても、全対象に適用する初回構築手順の矛盾は解消しないと分かった。
- Applies to: [PR #20](https://github.com/RCOSDP/RDM-developer-guide/pull/20), reviewed by REV(担当レビュワ, Codex Astra). A PR is a proposed change / PR は変更の提案です。
- Related: [Review index](README.md) · [r2](2026-11-05_dev2027_Strict_Reconstruction_PRs_r2.md) · [SPEC-06](../spec/06_documentation_conventions.md) · [SPEC-01](../spec/01_manifest.md) · [ADR-01](../decisions/ADR-01_Integration_Repository_Placement.md) · [Shared glossary](../reference/REF-01_Glossary.md).
- Related: [Review index](README.md) · r2 (kept in the private guide / 非公開のガイドに保管) · [SPEC-06](../spec/06_documentation_conventions.md) · [SPEC-01](../spec/01_manifest.md) · [ADR-01](../decisions/ADR-01_Integration_Repository_Placement.md) · [Shared glossary](../reference/REF-01_Glossary.md).
- Used by: [Integration status](../status/README.md), QAE and the owner for verification and acceptance / QAE(QA担当)と所有者の検証・採否判断。

---
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@

**Jump:** [English](#english) · [日本語](#japanese)

- Version / 版: 0.1 — 2026-11-06. **Learned:** passing automated checks does not establish the accuracy of step counts, warning categories or translated completion claims; those need comparison with the logs. / 自動検査の合格だけでは段数・警告の分類・翻訳の完了表現の正しさは分からず、ログとの照合が必要である。
- Version / 版: 0.2 — 2026-11-18. **Learned:** a public record links only to public records: the link to the Wiki PR #2 review, a record about a private repository that is kept in the private guide, became plain text. / 公開の記録からは公開の記録にだけリンクする。非公開のリポジトリについての Wiki PR #2 のレビューは非公開のガイドに保管しているので、リンクを外して文字だけにした。
0.1 — 2026-11-06. **Learned:** passing automated checks does not establish the accuracy of step counts, warning categories or translated completion claims; those need comparison with the logs. / 自動検査の合格だけでは段数・警告の分類・翻訳の完了表現の正しさは分からず、ログとの照合が必要である。
- Applies to: RCOSDP/RDM-developer-guide PR #31; REV(担当レビュワ, Codex Astra).
- Related: [Review index](README.md) · [SPEC-01](../spec/01_manifest.md) · [SPEC-06](../spec/06_documentation_conventions.md) · [Wiki PR #2 review](2026-11-06_RDM-wiki-frontend-dev2027_PR2_JS_Deps_Sync_r1.md).
- Related: [Review index](README.md) · [SPEC-01](../spec/01_manifest.md) · [SPEC-06](../spec/06_documentation_conventions.md) · Wiki PR #2 review (kept in the private guide / 非公開のガイドに保管).
- Used by: [DEMO-20](../demo/20_core_install_mac_studio.md) · [Status board](../status/README.md).

---
Expand Down
41 changes: 6 additions & 35 deletions docs/reviews/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@

**Jump:** [English](#english) · [日本語](#japanese)

- Version / 版: 0.2 — 2026-11-12. **Learned:** a review record that was never saved cannot be recreated truthfully, so the gap is stated and the posted pull-request comment is the reference. / 保存されなかったレビュー記録は、後から正確に作り直せない。欠落を明記し、投稿済みの PR コメントを参照先とする。
- Version / 版: 0.3 — 2026-11-18. **Learned:** a public index lists only records that are public: the list of the missing records of a private repository was taken out of this index, and section 5 now says that records of private repositories are kept in the private guide (owner decision 2026-11-17). / 公開の索引には公開の記録だけを載せる。非公開のリポジトリの欠落した記録の一覧をこの索引から外し、第 5 節には、非公開のリポジトリの記録は非公開のガイドに置くと書いた(所有者の判断 2026-11-17)。
0.2 — 2026-11-12. **Learned:** a review record that was never saved cannot be recreated truthfully, so the gap is stated and the posted pull-request comment is the reference. / 保存されなかったレビュー記録は、後から正確に作り直せない。欠落を明記し、投稿済みの PR コメントを参照先とする。
0.1 — 2026-11-05. **Learned:** every PR gets an independent review, and the review must be kept as its own record so that what was checked, and why, can be read later. / すべての PR は独立したレビューを受け、何をなぜ確かめたかを後から読めるよう、レビューは独自の記録として残す必要があると分かった。
- Normative for: [SPEC-04 Acceptance Tests](../spec/04_acceptance_tests.md) review section, [ADR-04 AI Autonomy and Roles](../decisions/ADR-04_AI_Autonomy_and_Roles.md) review section.
- Related: [../README.md](../README.md) · [handoff/](../handoff/README.md) · [status/](../status/README.md)
Expand Down Expand Up @@ -49,24 +50,9 @@ A review record includes:
3. Describe scope, findings, and approval decision.
4. Link from the PR as "reviewed by REV (Codex Astra)".

### 5. Missing records and the pull-request comments that stand in for them
### 5. Review records of private repositories

Nine review records written on 2026-11-10 were never saved in this folder: they lived only in a scratch directory of a session that ended. They are **not recreated**, because a record rebuilt from memory would not say what REV actually checked. Each one was posted as a comment on its pull request by REV (Codex Astra), and that comment is the reference. The repositories are private; they are named here by name and number only. The comment ID is the number at the end of the comment's address on the pull request page.

```toon
missing_records[9]{repository,pr,round,comment_id,posted_utc,verdict,head}:
RDM-osf.io-dev2027,#8,r1,6757009993,"2026-11-10 02:12","changes requested",e7f23e13141f
RDM-osf.io-dev2027,#8,r2,6758141691,"2026-11-10 03:28","changes requested",8bb07f17c2
RDM-osf.io-dev2027,#8,r3,6759472716,"2026-11-10 05:03","pass (R2 delta)",49e5521451
RDM-osf.io-dev2027,#10,r1,6759171742,"2026-11-10 04:41","changes requested",5355858363b6
RDM-osf.io-dev2027,#11,r1,6759274738,"2026-11-10 04:48","changes requested",75ceaf5cb492
RDM-osf.io-dev2027,#11,r2,6760403905,"2026-11-10 06:08","changes requested",58ba83af4b7c
RDM-osf.io-dev2027,#11,r3,6763524193,"2026-11-10 09:13","pass (delta 58ba83a..3eb4042)",3eb4042
RDM-osf.io-dev2027,#12,r1,6763575801,"2026-11-10 09:16","changes requested",aa30a37d
RDM-osf.io-dev2027,#13,r1,6763600948,"2026-11-10 09:17","changes requested",ef9e64261b
```

The owner decided on 2026-11-12 to note the gap and refer to these comments. From now on a review record is placed in this folder as soon as REV finishes it.
Review records of pull requests in the private RDM-<name>-dev2027 repositories are not kept in this public repository. The owner decided on 2026-11-17 that they are kept in the private copy of this guide. Review records of pull requests in this repository are kept here.

---

Expand Down Expand Up @@ -107,24 +93,9 @@ The owner decided on 2026-11-12 to note the gap and refer to these comments. Fro
3. 範囲、調査結果、承認決定を記述する。
4. PR から「REV(Codex Astra)レビュー済み」としてリンクする。

### 5. 欠落した記録と、代わりの PR コメント

2026-11-10 に書かれたレビュー記録 9 件は、この場所に保存されませんでした。終了したセッションの作業用ディレクトリにだけあったためです。記憶から作り直した記録は REV が実際に何を調べたかを語れないので、**作り直しません**。各記録は、REV(Codex Astra)が PR へのコメントとして投稿しており、そのコメントを参照先とします。リポジトリは非公開なので、ここでは名前と番号だけを書きます。コメント ID は、PR のページにあるコメントのアドレスの末尾の数字です。

```toon
missing_records[9]{repository,pr,round,comment_id,posted_utc,verdict,head}:
RDM-osf.io-dev2027,#8,r1,6757009993,"2026-11-10 02:12","changes requested(要修正)",e7f23e13141f
RDM-osf.io-dev2027,#8,r2,6758141691,"2026-11-10 03:28","changes requested(要修正)",8bb07f17c2
RDM-osf.io-dev2027,#8,r3,6759472716,"2026-11-10 05:03","pass(R2 の差分)",49e5521451
RDM-osf.io-dev2027,#10,r1,6759171742,"2026-11-10 04:41","changes requested(要修正)",5355858363b6
RDM-osf.io-dev2027,#11,r1,6759274738,"2026-11-10 04:48","changes requested(要修正)",75ceaf5cb492
RDM-osf.io-dev2027,#11,r2,6760403905,"2026-11-10 06:08","changes requested(要修正)",58ba83af4b7c
RDM-osf.io-dev2027,#11,r3,6763524193,"2026-11-10 09:13","pass(差分 58ba83a..3eb4042)",3eb4042
RDM-osf.io-dev2027,#12,r1,6763575801,"2026-11-10 09:16","changes requested(要修正)",aa30a37d
RDM-osf.io-dev2027,#13,r1,6763600948,"2026-11-10 09:17","changes requested(要修正)",ef9e64261b
```
### 5. 非公開のリポジトリのレビュー記録

所有者は 2026-11-12 に、欠落を明記してこれらのコメントを参照することに決めました。以後、REV のレビュー記録は完了したらすぐにこの場所へ収めます。
非公開の RDM-<name>-dev2027 リポジトリの PR のレビュー記録は、この公開リポジトリには置きません。所有者は 2026-11-17 に、それらをこのガイドの非公開の複製に保管すると決めました。このリポジトリの PR のレビュー記録は、ここに置きます。

---

Expand Down
Loading