Repository navigation
refactor(core): log the errors that were swallowed silently (#1507) - #1717
Merged
Merged
Conversation
…and driver cleanup paths leave a line in the debug log (#1507)
github-actions
Bot
added
error-handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1507
logIgnored(where, error)(core/util/log_ignored.dart) writes one debug line for an error the caller goes on from. The 58 barecatch (_) {}inlib/corewhere a failure can matter later now use it: extension install backup/staging cleanup, SSL certificate paths and temp-key cleanup,connection_environmentand MCP access-store JSON, MCP session teardown, extension driver teardown, sandbox process kill, secrets-store legacy cleanup,LocalDb, SSH tunnel manager and the four drivers' close paths.No behaviour change: every site still continues exactly as before. The ~30 bare catches left are in
lib/features(UI value parsing, clipboard) and are best handled case by case, so #1507 stays open for them.