Repository navigation
feat(dx): querya-testdb-<db> images (#1487, part 3b) - #1620
Merged
Merged
Conversation
…art 3b) Dockerfile.testdb per database (postgres, mysql 8.0 native password, mongo, clickhouse, redis), built and smoke-tested on pull requests, pushed with the release version and latest after a Release.
github-actions
Bot
added
bug
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1487, step 3: test database images for extension authors, seeds included, no bind mounts.
docker/<db>/Dockerfile.testdbfor postgres, mysql, mongo, clickhouse, redis. MySQL is 8.0 withmysql_native_password, like CI. Redis has no init directory, so a small entrypoint starts the server, runsseed.shand keeps serving.testdb-images.yml: the matrix is the list ofdocker/*/Dockerfile.testdb, so a new database appears by adding that file. Pull requests build and smoke-test (healthy, seeded table or key present). After a Release, or by hand, it pushesghcr.io/queryahub/querya-testdb-<db>:<version>and:latest.Dockerfile.testdb.The seeds run on the first start of an empty data directory (the database images' own init mechanism), not at build time. Docker is not running here, so nothing was built locally; the PR run is the first build.