Repository navigation
fix(connections): confirm before removing a connection and leave its workspace - #1434
Merged
Merged
Conversation
…workspace Remove connection deleted the connection at once from the context menu, and the workspace of the removed connection stayed open with the status bar still naming it. Removal now asks in a destructive QueryaConfirmDialog, and the shell goes back to the start screen when the removed connection was the open one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while driving a build of `dev` (UI consistency review).
Problem
Remove connection in the context menu deleted the connection at once, with its saved password. And when the removed connection was the open one, its workspace stayed on screen and the status bar kept naming it.
Change
Tests
No existing test removes through the menu (the e2e helper removes through `LocalDb`). Not run locally; CI is the check.