Skip to content

perf(mysql): add StringInternPool to MySqlSqlExecutionDelegate row conversion - #1410

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/1356-mysql-string-intern-pool
Oct 11, 2026
Merged

ZhuchkaTriplesix merged 1 commit into
devfrom
issue/1356-mysql-string-intern-pool

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Closes #1356

  • Introduces a StringInternPool in MySqlSqlExecutionDelegate during row conversion to display strings.
  • Passes pool to mysqlResultCellToDisplayString so duplicate strings, booleans, and nulls share common memory instances.
  • Adds periodic UI thread yielding via kResultStringConvertYieldEvery for smoother large-batch processing, consistent with Postgres and SQLite delegates.
  • Adds test coverage for string interning in mysql_grid_types_test.dart.

@github-actions github-actions Bot added performance Theme parser epic label: performance mysql MySQL database driver and workspace backend Backend database driver execution and queries P3 Low priority / Polish & Enhancements labels Oct 10, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit dde34da into dev Oct 11, 2026
13 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/1356-mysql-string-intern-pool branch October 11, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Backend database driver execution and queries mysql MySQL database driver and workspace P3 Low priority / Polish & Enhancements performance Theme parser epic label: performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant