Repository navigation
feat(ui): QueryaButton on Flutter primitives, no shadcn - #1406
Merged
ZhuchkaTriplesix merged 1 commit intoOct 10, 2026
Merged
Conversation
primary / secondary / ghost / destructive plus an icon-only constructor, sized by QueryaControlSize, with hover / pressed / keyboard-focus ring / disabled / loading states from the workbench, Enter and Space activation, non-wrapping label, and button semantics. Closes #1334.
ZhuchkaTriplesix
merged commit Oct 10, 2026
a0016d2
into
issue/1333-control-metrics-tokens
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1334 (part of epic #1331)
Stacked on #1404 (control metrics,
issue/1333-control-metrics-tokens): this PR targets that branch so the diff shows only the button. Once #1404 is merged, retarget todev(or merge #1404 first and GitHub will do it).What
lib/shared/widgets/querya_button.dart, exported fromwidgets.dart, with noshadcn_flutterimport:Common parameters:
size(default fromQueryaControlScope, thenmd),icon,trailing,shortcutHint,loading,tooltip,isActive,compact,autofocus,semanticLabel.FocusableActionDetector.onShowFocusHighlight, drawn as a foreground decoration so it never shifts layout), disabled (50 %), loading (spinner in the icon's place, or over the hidden label, width kept; not pressable), selected (isActive).context.workbenchand the theme foreground; transitions useQueryaMotion(instant under reduced motion).QueryaControlSize.Not in this PR
QueryaActionButtonis untouched. The issue asks for a deprecated thin wrapper, but it has its own tests that look for shadcn button types and 17 call sites; it is swapped during the migration (refactor(ui): migrate toolbars, panels and the self-made buttons to QueryaButton #1337) so each change stays reviewable.QueryaSplitButton,QueryaMenuButton,QueryaDialogActionsare feat(ui): QueryaSplitButton, QueryaMenuButton and QueryaDialogActions #1335.Tests
test/shared/widgets/querya_button_test.dart: tap, disabled and loading do not fire, Enter / Space activate, height per size, icon-only is square, compact keeps the label as tooltip, loading keeps width, long label ellipsizes without overflow, tooltip delay iskQueryaTooltipWait, semantics flags, and a source guard that the file imports noshadcn_flutter.Not run locally; CI is the check.