Repository navigation
docs(ui): the Querya button and control standard - #1403
Merged
Merged
Conversation
One control scale (sm 28 / md 32 / lg 36), the four variants and their roles, the states, layout and dialog-footer rules, canonical Cancel / Close / Retry / Create roles, and the mapping from shadcn and ad-hoc buttons. Closes #1332.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1332 (part of epic #1331)
The standard, written before any component code so #1333-#1335 and the migration (#1337, #1338) implement and apply one set of rules. It lands in
docs/ui-kit.md:sm 28 / md 32 / lg 36, with icon size, label size, padding and gap per size; radius is one token; a hit area is never belowsm.primary,secondary,ghost,destructive, as roles (no colour arguments).ghostfirst, exactly oneprimary/destructivelast,Esc/Enter, canonical roles for Cancel / Close / Retry / Create.Docs only; no code changes. The Obsidian note named in the issue is outside the repo and is not touched here.
Decisions to confirm in review (they are numbers in the tables, cheap to change before #1333 turns them into tokens): sizes 28 / 32 / 36, icon sizes 15 / 16 / 18, radius 6,
Retryassecondary.