Repository navigation
perf(theme): cache the hash of token colours instead of rehashing per build - #1401
Merged
Merged
Conversation
QueryaCodeEditor and SyntaxHighlightService hashed every TokenColorRule on each call. The hash is now computed once per tokenColors list (an Expando keyed by the list, so lerp/copyWith themes sharing it reuse it). Closes #1353.
github-actions
Bot
added
theme
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1353
Problem
QueryaCodeEditor._syncThemeIfNeededranObject.hashAll(queryaTheme.tokenColors)on every build, andSyntaxHighlightService.createPairdid the same for its cache key. An imported VS Code theme has 100-300+ rules, so every cursor blink or ancestor rebuild iterated them all.Change
QueryaTheme.tokenColorsHash: computed once pertokenColorslist and cached in anExpandokeyed by the list.Why an Expando keyed by the list
QueryaThemehas a const constructor (the defaults are const), so alate finalfield is not allowed. AndQueryaTheme.lerp/copyWithcreate a new theme per animation frame that reuses the sametokenColorslist, so a per-theme cache would be recomputed every frame; keyed by the list it is computed once.Tests
querya_theme_token_colors_hash_test.dart: equalsObject.hashAll, stable, shared acrosscopyWith/lerp, differs for different rules, empty-list hash for the defaults.Not run locally; CI is the check.