Repository navigation
perf(theme): single-pass string literals in stripJsonc - #1400
Merged
Merged
Conversation
stripJsonc scanned every string literal twice (copy, then skip) and built a StringBuffer per literal. A single scan now finds the closing quote and the literal is written as a substring. Closes #1360.
github-actions
Bot
added
theme
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1360
Problem
For every
"stripJsoncran_copyStringLiteral(char by char into a newStringBuffer) and then_skipStringLiteralover the same characters again: two scans and one buffer + string per literal, thousands of times for a VS Code theme.Change
One helper,
_stringLiteralEnd, finds the end of the literal in a single pass (on code units, no per-character strings);stripJsoncwritesinput.substring(start, end). Same end offsets as the old skip (unterminated literal goes to the end of input, a backslash escapes the next character), so the output is byte for byte the same.Tests
Added to
jsonc_preprocessor_test.dart: escapes preserved, comment markers and,]/,}inside strings survive, unterminated string, trailing backslash, and a 200-token document with comments and trailing commas. The existing tests are unchanged.Not run locally; CI is the check.