Repository navigation
fix(a11y): keyboard close and a 24 px close target in QueryaTabStrip - #1398
Merged
Merged
Conversation
- Delete / Backspace close the focused tab (honouring canClose) - the close button hit area is 24x24; padding shrinks so the tab keeps its size - the close button is its own labelled semantics button with a tooltip Closes #1372.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1372
Problem
ExcludeSemantics.Change
_onKeyEvent: Delete and Backspace callonClose(index), only whencanCloseallows it.ExcludeSemanticsnow wraps only the label text. The close button is acontainerSemantics(button, label: 'Close <tab> tab')inside a tooltip, so it is a separate node under the tab.Not in this PR
The close button is not a separate Tab stop; Delete / Backspace on the focused tab is the keyboard path. Golden
querya_tab_strip.png(taggolden, excluded from CI) may need a refresh if the 1 px padding shift is visible.Tests
test/shared/querya_tab_strip_test.dart: Delete, Backspace,canCloserespected, and the close button's size, semantics label, tooltip and tap.Not run locally; CI is the check.