Repository navigation
fix(a11y): semantics for QueryaDropdown trigger and menu items - #1396
Merged
Merged
Conversation
The trigger is now a Semantics button carrying the current value, the hint and whether the menu is expanded; each menu item reports button, enabled and selected. Closes #1371.
github-actions
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1371
Problem
QueryaDropdownhandled keys and focus but had noSemantics: the trigger read as unlabelled text, a screen reader could not tell whether the menu was open, and menu items did not say which one is selected.Change
Semantics(button: true, enabled: widget.enabled, expanded: controller.isOpen, value: label, hint: widget.hint).MenuAnchorrebuilds the trigger on open/close, soexpandedfollows the menu.Semantics(button: true, enabled: ..., selected: item.value == value)around theMenuItemButton(its own label semantics merge with it).Tests
test/shared/widgets/querya_dropdown_semantics_test.dart: trigger flags (value, hint, collapsed), disabled state, and the expanded flag plus selected / unselected item after opening.Not run locally; CI is the check.