Repository navigation
fix(a11y): focus ring and state semantics for QueryaIconButton - #1395
Merged
Merged
Conversation
…eryaToolbarButton Track keyboard focus with InkWell.onFocusChange and draw a 2px ring in the theme's ring colour, and wrap both buttons in Semantics (button, enabled, selected) so screen readers announce active toggles. Closes #1370.
github-actions
Bot
added
bug
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1370
Problem
QueryaIconButton/QueryaToolbarButtongave keyboard users no visible focus indicator and screen readers no state: an active toggle (word wrap, filter, masking…) was announced as a plain button.Change
InkWell.onFocusChange; while focused the shape draws a 2px border in the theme'sringcolour (it replaces the active border for that moment).Semantics(button: true, enabled: onPressed != null, selected: isActive). The tooltip keeps providing the label, so it is not duplicated.Notes
selectedrather thantoggled: most callers are not real toggles andisActive: falsemust not be announced as "off".Not run locally; CI is the check.