Repository navigation
test(recovery): fix hanging retry test that stalls Tests (rest) - #1389
Merged
Merged
Conversation
The retry widget test awaited real file and SQLite I/O inside FakeAsync, which never completes, so Tests (rest) stalled until the 10 minute test timeout on every PR. Do the I/O in tester.runAsync, wait for the retry callback there, and add a 30s test timeout so a regression fails fast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
`Tests (rest)` has been timing out after ~12 minutes on every run since #1382 landed in `dev`. The only failing test is
`querya_startup_recovery_app_test.dart: QueryaStartupRecoveryApp widget retry callback triggers when database can be opened`
(`Test timed out after 10 minutes`). All other 508 tests in the section pass.
Cause
The test is a `testWidgets` (FakeAsync) but awaits real I/O directly: `LocalDb.close()`, `File.exists()/delete()`, and the
Retry handler's `LocalDb.open()` (sqflite ffi). Real I/O never completes in FakeAsync without `tester.runAsync`, so the test hangs.
Fix
Test-only change; not run locally, CI is the check.