Repository navigation
fix(ssh): openTunnel leaks sockets on its failure paths, ignores a missing key file, and dials twice for concurrent callers - #1388
Merged
ZhuchkaTriplesix merged 3 commits intoOct 10, 2026
Conversation
…ssing key file, and dials twice for concurrent callers Closes #1312
github-actions
Bot
added
bug
- read and validate the private key before opening any socket, so a missing or empty key file fails without connecting - track the raw jump host socket and destroy it in the failure path instead of relying on the client to close it - unawaited the pending-tunnel map removal (unawaited_futures)
3 tasks
ZhuchkaTriplesix
deleted the
issue/1312-ssh-opentunnel-leaks-singleflight
branch
October 11, 2026 15:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1312