Skip to content

fix(updater): use robocopy mirror on Windows to remove obsolete DLLs and assets during in-place updates #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZhuchkaTriplesix merged 1 commit into from
Oct 10, 2026
Merged

fix(updater): use robocopy mirror on Windows to remove obsolete DLLs and assets during in-place updates #1383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/core/updater/installers/update_install_utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,11 @@ if %ERRORLEVEL%==0 (
timeout /t 1 /nobreak >NUL
goto wait
)
xcopy /E /Y /I "%SRC%\\*" "%DST%\\"
robocopy "%SRC%" "%DST%" /MIR /XD "QueryaData" /XF ".portable" /R:2 /W:1
if %ERRORLEVEL% GEQ 8 (
echo Update failed with error %ERRORLEVEL%
exit /b %ERRORLEVEL%
)
start "" "%EXE%"
del "%~f0"
''';
Expand Down
4 changes: 3 additions & 1 deletion test/core/updater/update_platform_installer_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ void main() {
);
});

test('windows batch script waits for pid', () {
test('windows batch script waits for pid and uses robocopy mirror with exclusions', () {
final batch = buildWindowsReplaceBatch(
pid: 99,
sourceDir: 'C:\\tmp\\new',
Expand All @@ -119,6 +119,8 @@ void main() {
);
expect(batch, contains('set PID=99'));
expect(batch, contains('querya_desktop.exe'));
expect(batch, contains('robocopy "%SRC%" "%DST%" /MIR /XD "QueryaData" /XF ".portable" /R:2 /W:1'));
expect(batch, contains('if %ERRORLEVEL% GEQ 8'));
});
});

Expand Down
Loading