Repository navigation
fix(db): reflect underlying driver socket state in isConnected and mark session closed on socket drop (#1373) - #1379
Merged
Conversation
…rk session closed on socket drop - Check _conn.isOpen in PostgresConnection.isConnected. - Check _conn.connected and listen to onClose in MysqlConnection. - Track socket.done and disconnect on socket errors in RedisConnection. - Reset stale closed sockets upon reconnecting. - Add forceClose triggers on connection lost / host unreachable errors. - Add unit tests for socket state reflection and pool drop reconnect. Closes #1373
github-actions
Bot
added
bug
… on the socket watcher (#1373)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reflect underlying driver socket state in
isConnectedacrossPostgresConnection(_conn.isOpen),MysqlConnection(_conn.connected,onClose), andRedisConnection(socket.done). When remote database servers drop sockets or connections fail withConnectionLostException/HostUnreachableException,forceClose()is triggered so pooled sessions proactively reconnect rather than failing in an infinite error loop.Linked issue
Closes #1373
Checklist
dev