Repository navigation
fix(results): Grid / Groupings / Charts tabs no longer clip or overlap - #1272
Merged
Merged
Conversation
The strip sat in a 240 x 32 box. A tab row is taller than 32 (8 px padding on both sides plus a 2 px focus border), so the tabs were clipped, and at a larger UI or text scale 'Groupings' ran into its neighbours. QueryaTabStrip gets dense (4 px vertical padding) and the strip is no longer boxed. The chart type strip (Bar / Line / Pie) had the same fixed 260 x 32 box and gets the same fix. A test lays the tabs out at 1.0, 1.3 and 1.6 text scale and checks they do not overlap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reported from the 120 Hz build: the Grid / Groupings / Charts buttons in the results toolbar look crooked and run into each other (PostgreSQL, but it is the shared results tab).
Cause: the strip sat in a fixed
240 x 32box. A tab is taller than 32 (8 px vertical padding on both sides plus the 2 px focus border), so the tabs were clipped by the box, and at a larger UI or text scale "Groupings" no longer fit its share of 240 px and pushed into its neighbours.Fix:
QueryaTabStripgetsdense(4 px vertical padding), sized for toolbars.IntrinsicWidth).260 x 32box and gets the same fix.Test: the three tabs are laid out at 1.0, 1.3 and 1.6 text scale: no overlap, no layout exception.
Not touched: the other
QueryaTabStripusers keep their normal padding. If the Data | Relations strip or the workspace tab bars look off too, tell me which and where.Test plan