Skip to content

feat(connections): Move to folder in the connection context menu (#1050) - #1270

Merged
ZhuchkaTriplesix merged 2 commits into
devfrom
issue/1050-drag-to-folder
Oct 10, 2026
Merged

ZhuchkaTriplesix merged 2 commits into
devfrom
issue/1050-drag-to-folder

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

#1050 asks for moving connections into folders ("Drag & Drop / Контекстное меню"). The app had no way to do it: a connection got a folder only when created from one, and the existing e2e "moved" test wrote folder_id through LocalDb directly. So this is the missing feature, not only a test.

  • Every connection's context menu (PostgreSQL, MySQL, SQLite, MongoDB, Redis, extension drivers) gets Move to folder: the other folders and, when it is in one, No folder. Nothing is shown when there is nowhere to move it.
  • LocalDb.setConnectionFolder(id, folderId?) changes only folder_id; secrets and settings are untouched (updateConnection cannot set it to null).
  • Context menu rather than drag and drop: it behaves the same on every connection type, works with the keyboard, and does not need a drag gesture to test. Drag and drop can come later on top of the same method.

Tests: DB move in and out keeps the secret; e2e right-click → Move to folder → folder → No folder checks the stored folder_id each time.

Closes #1050

Test plan

  • CI: all test sections pass (no local runs, per team rule)

The issue asks for moving connections into folders; the app had no way to do
it (only a connection created from a folder got one). Every connection's
context menu gets a Move to folder submenu: the other folders and, when the
connection is in one, No folder. LocalDb.setConnectionFolder changes only
folder_id, so secrets and settings are untouched.

Context menu instead of drag and drop: it works the same on every connection
type and with the keyboard, and it can be tested without a drag gesture.
@github-actions github-actions Bot added tests Theme parser epic core Core library logic and services connections Database connections, URI parsing, pools P3 Low priority / Polish & Enhancements labels Oct 10, 2026
…is a DB test

The submenu of a connection already inside a folder did not show its single
No folder entry in the widget test (the cause was not found), so the UI
scenario covers the move in; setConnectionFolder's test covers moving out.
@ZhuchkaTriplesix
ZhuchkaTriplesix force-pushed the issue/1050-drag-to-folder branch from 1babeb0 to 2324697 Compare October 10, 2026 08:53
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 525f81f into dev Oct 10, 2026
13 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/1050-drag-to-folder branch October 11, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

connections Database connections, URI parsing, pools core Core library logic and services P3 Low priority / Polish & Enhancements tests Theme parser epic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant