Repository navigation
test(e2e): a connection created from a folder lands in it (#1050) - #1265
Merged
Merged
Conversation
…1050) Right-click on a folder, New connection, pick the type by its card, type a URI and a name, Save: the stored row carries the folder's id.
github-actions
Bot
added
tests
On a first launch without connections the tour opens once its settings read returns, and its scrim covered the folder the scenario right-clicks.
ShadcnApp defaults to a sheet on the platform the test binding reports, and a sheet needs a DrawerOverlay: a right click on a folder asserted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The folder scenario removed in c2ffcc8 failed for the same reason as the form scenarios (the type was never selected, see #1256). It is back, using the card tap:
Not covered: moving a connection into a folder (drag and drop) and removing a folder; the first needs a drag gesture on the tree, the second a decision on what happens to its connections. #1050 stays open for them.
Refs #1050
Test plan