Repository navigation
feat(sql-workspace): elapsed time in the results toolbar, icon-only toolbar on a narrow window (#1150) - #1263
Merged
Merged
Conversation
…on a narrow toolbar (#1150) - The results toolbar shows a badge with how long the run took (14 ms, 1.2 s, 2 min 5 s); the whole script for a multi-statement run. - Below 900 px the Run, Explain and Cancel labels and the Session menu text hide and the icons stay; the labels become tooltips. QueryaActionButton gets compact for that.
github-actions
Bot
added
enhancement
…s on a narrow window
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two of the three items #1150 still lacked:
14 ms,1.2 s,2 min 5 s), fromSqlExecutionResult.elapsed, or the whole run for a multi-statement script. Cleared when a new run starts.QueryaActionButtongetscompactfor that. The toolbar was already one row (it scrolls sideways).Already in place, no change: Diagram is hidden without a diagram source (
showDiagram, off for extension drivers).Not done: Commit / Rollback have no icons, so they keep their labels when compact.
Refs #1150
Test plan