Skip to content

test(table): close the acceptance gaps of #1149 - #1262

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/1149-relations-tests
Oct 10, 2026
Merged

ZhuchkaTriplesix merged 1 commit into
devfrom
issue/1149-relations-tests

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Summary

#1250 added most of the #1149 widget tests. This covers what its acceptance still lacked:

  • SQLite joins PostgreSQL and MySQL in the check that referenced tables sit left and referencing ones right.
  • Opening a neighbour through the host. A double click without a custom onOpenNeighbour goes through QueryaCommandHost.onOpenSchemaObject: it opens orders in public, as a table, and asks for the new tab to start in Relations. The existing test covered only the custom callback.
  • Data → Relations → Data keeps the quick filter, as well as the staged edits and the page.
  • A materialized view offers no switch, like a view.

pumpGenericTableView takes isMaterializedView and onOpenSchemaObject; with the latter, the view is wrapped in a QueryaCommandHost.

Not covered here: "Return to …" after opening a neighbour. That button belongs to the workspace home's last selected object, not to the table view.

Refs #1149

Test plan

  • CI: all test sections pass (no local runs, per team rule)

- SQLite joins PostgreSQL and MySQL in the left/right layout check.
- A double click on a neighbour without a custom callback opens it through
  QueryaCommandHost.onOpenSchemaObject (orders in public, a table) and asks
  for its tab to start in Relations.
- Data, Relations, Data keeps the quick filter, not only staged edits and
  the page.
- A materialized view does not offer the switch, like a view.

The table view harness takes isMaterializedView and onOpenSchemaObject.
@github-actions github-actions Bot added enhancement New feature or request frontend Theme parser epic label: frontend ui User interface components and widgets P2 Medium priority / Parity & Refactoring labels Oct 10, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 4eac948 into dev Oct 10, 2026
13 checks passed
@ZhuchkaTriplesix
ZhuchkaTriplesix deleted the issue/1149-relations-tests branch October 11, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend Theme parser epic label: frontend P2 Medium priority / Parity & Refactoring ui User interface components and widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant