Repository navigation
test(table): close the acceptance gaps of #1149 - #1262
Merged
Merged
Conversation
- SQLite joins PostgreSQL and MySQL in the left/right layout check. - A double click on a neighbour without a custom callback opens it through QueryaCommandHost.onOpenSchemaObject (orders in public, a table) and asks for its tab to start in Relations. - Data, Relations, Data keeps the quick filter, not only staged edits and the page. - A materialized view does not offer the switch, like a view. The table view harness takes isMaterializedView and onOpenSchemaObject.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1250 added most of the #1149 widget tests. This covers what its acceptance still lacked:
onOpenNeighbourgoes throughQueryaCommandHost.onOpenSchemaObject: it opensordersinpublic, as a table, and asks for the new tab to start in Relations. The existing test covered only the custom callback.pumpGenericTableViewtakesisMaterializedViewandonOpenSchemaObject; with the latter, the view is wrapped in aQueryaCommandHost.Not covered here: "Return to …" after opening a neighbour. That button belongs to the workspace home's last selected object, not to the table view.
Refs #1149
Test plan