Repository navigation
fix(pg): closing a sequence or routine view releases its lease without interrupting the shared session (#1215) - #1236
Merged
Conversation
…t interrupting the shared session (#1215) Closing the sequence or routine view while it was loading interrupted the read-only session of the database: the same shared session the tree, the table tabs, the Relations view and MCP use. Those views now only release their lease, as the table browser does since #1215.
github-actions
Bot
added
bug
This was referenced Oct 9, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1215
What was wrong
Closing the sequence or routine view while it was loading called
PostgresService.interrupton the read-only session of the database. That session is shared with the tree, the table tabs, the Relations view and MCP, so closing one view broke whatever else was using it. This is the same bug #1215 fixed for the table browser; these two views were the follow-up that issue left out.Changes
interruptIfBusyparameter, which did nothing else, is removed.Not verified locally
Tests were not run locally, per the project rule. There is no unit test here: the views need a PostgreSQL session, and the change removes a call rather than adding behaviour.