Repository navigation
ui(results): groupings empty state uses the UI kit empty state (#1162) - #1229
Merged
Merged
Conversation
github-actions
Bot
added
enhancement
Grid scroll benchmark
Informational only (threshold 5%). Shared CI runners are noisy; re-run before trusting a single result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1162
What was wrong
The groupings view showed
No data available for grouping.as a bare muted line, the last raw empty state in the results (#1162 asks forQueryaEmptyStatein the results).Changes
QueryaEmptyState: "No data to group", with a hint to run a query that returns rows.Not in this PR
lib/features/.Not verified locally
Tests were not run locally, per the project rule.