Repository navigation
feat(export): light palette by default for chart and ERD SVG, setting for the current theme (#1163) - #1226
Merged
Conversation
… for the current theme (#1163) Chart and ERD exports followed the current theme inconsistently: the chart SVG took the workbench colours, the ERD SVG always used light literals. Exports now use one light palette for documents by default. An export-theme setting, off by default, switches both to the colours of the current theme; the Export menus of the chart and the diagram offer the toggle.
github-actions
Bot
added
enhancement
…e; drop an unused import (#1163) Reading the setting touches the local database; without one (tests, a damaged store) the export must still run, so it uses the light default. The chart file imported app_toast next to widgets, which already provides it.
The second SVG export of the test reads the setting as well, so one pump was not enough for it to be saved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1163
What was wrong
Chart and ERD exports followed different rules. The chart SVG took the workbench colours, so exported from a dark theme it had a dark background; the ERD SVG always used light literals, while its PNG was a screenshot of the current theme.
Changes
export_current_theme, off by default (AppSettings.getExportCurrentTheme).ChartSvg.light,ErdSvgColors()).Not in this PR
flutter_svgrasterising API without an analyzer run.Not verified locally
Tests were not run locally, per the project rule.