Skip to content

fix(table): closing a table tab releases its lease without interrupting the shared session (#1215) - #1221

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
fix/1215-tab-dispose-shared-session
Oct 9, 2026
Merged

ZhuchkaTriplesix merged 1 commit into
devfrom
fix/1215-tab-dispose-shared-session

Conversation

@ZhuchkaTriplesix

Copy link
Copy Markdown
Member

Refs #1215

What was wrong

Closing a table browser tab called cancel(interruptIfBusy: true). Despite the name, the PostgreSQL, MySQL and SQLite table delegates interrupted the readOnly and tableWrite sessions of the database unconditionally. Those sessions are the same objects the tree, the other table tabs, the Relations view and MCP use, so closing one tab dropped the connection under the others.

Changes

Behaviour change

  • A table query still running when its tab closes is no longer cut on the server; it runs until it finishes or times out. Its result is dropped.
  • The ER diagram's table adapter forwards cancelQuery to cancel, so it no longer interrupts anything. The Relations view does not call it today.

Not in this PR

Not verified locally

Tests were not run locally, per the project rule.

…ng the shared session (#1215)

Closing a table browser tab called cancel(interruptIfBusy: true), which
interrupted the read-only and table-write sessions of the whole database. Those
sessions are shared with the tree, other table tabs, the Relations view and
MCP, so one close dropped their connection. cancel no longer closes a pooled
session; a statement still running finishes or times out on its own, and the
tab's dispose releases its lease.
@github-actions github-actions Bot added bug Something isn't working stability Theme parser epic label: stability core Core library logic and services connections Database connections, URI parsing, pools P1 High priority / Core capability labels Oct 9, 2026
@ZhuchkaTriplesix
ZhuchkaTriplesix merged commit 9dc42fa into dev Oct 9, 2026
14 checks passed
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

Grid scroll benchmark

metric base PR change
p50 8.83 ms 9.67 ms +9.5% ⚠️
p90 14.32 ms 16.55 ms +15.6% ⚠️
p99 32.34 ms 38.14 ms +17.9% ⚠️
stutters 346.00 335.00 -3.2%

Informational only (threshold 5%). Shared CI runners are noisy; re-run before trusting a single result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working connections Database connections, URI parsing, pools core Core library logic and services P1 High priority / Core capability stability Theme parser epic label: stability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant