Repository navigation
test(e2e): close the app in small fake-time steps - #1211
Merged
Merged
Conversation
Advancing the fake clock in 10 s steps still fired sqflite's lock warning six times per run in the smoke and palette suites: a request that waits on real I/O has its 10 s timer due in one step. The same 60 s now run in 100 ms steps, with real time between them, so the request finishes before its timer is due.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After #1206 the CI log still showed six
database has been lockedwarnings. Attributed by their test group, all six come frome2e_smoke_testande2e_command_palette_navigation_test, which both end withE2eAppHarness.close.closeadvanced the fake clock in 10 s steps. A database request still waiting on real I/O has its 10 s lock timer due in one such step, so the warning fires even though the app holds no lock.Change
Not verified locally
Tests were not run locally, per the project rule. Expected in CI: no
database has been lockedlines in the smoke and palette suites.