Repository navigation
ci: run a MySQL server for the live database test in core-data - #1210
Merged
Merged
Conversation
The live MySQL COM_QUERY test skipped in CI because no server listened on 127.0.0.1:3306, so the drain behaviour against a real server was never checked. The core-data job now starts a MySQL 8 container with the querya user and database the test reads from its defaults, and waits until it answers.
The live test failed: MySQL 8's default auth plugin, caching_sha2_password, needs a secure connection, and the client connects without TLS here. The test server now uses mysql_native_password.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1207
Why
test/core/database/stream_take_drain_test.dartchecks COM_QUERY draining against a live MySQL. It skipped in CI with "MySQL is not listening on 127.0.0.1:3306", so the behaviour against a real server was never checked.Change
core-datajob only, and only on GitHub-hosted runners, amysql:8.0container starts on port 3306 with thequeryauser and database the test reads from its defaults.mysqladmin pinganswers, and fails with the container log if it never does.Not verified locally
Tests were not run locally, per the project rule. Expected in CI: the live test runs and passes, and the core-data job takes a little longer for the container start.